[Canvas] Fix asset image preview #54659
Merged
poffdeluxe merged 3 commits intoelastic:masterfrom Jan 14, 2020
Merged
Conversation
poffdeluxe
added
review
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
poffdeluxe
force-pushed
the
bug/asset-images-not-displaying
branch
from
5139be6 to
d3ee3bc
Compare
Contributor
|
@poffdeluxe did you test the Logs workpad too? That one has the SVGs that wouldn't load for me. |
Contributor
Author
|
@ryankeairns Logs assets are lookin' good to me: |
ryankeairns
approved these changes
Jan 13, 2020
Contributor
ryankeairns
left a comment
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM, checked all three sample workpads plus one of my own.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
poffdeluxe
added a commit
to poffdeluxe/kibana
that referenced
this pull request
Jan 14, 2020
* fix image preview * Center image in asset box * Updating snapshot Co-authored-by: Ryan Keairns <rkeairns@chef.io>
poffdeluxe
added a commit
that referenced
this pull request
Jan 14, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* fix image preview * Center image in asset box * Updating snapshot Co-authored-by: Ryan Keairns <rkeairns@chef.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modification of the CSS to get images displaying again in the asset manager while also maintaining a nice aspect ratio.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers